[discover] Support ES|QL statements without FROM clause #179020
Conversation
mattkime
added
Team:DataDiscovery
mattkime
changed the title
mattkime
added
the
release_note:skip
| if (indexPatternFromQuery === '') { | ||
| return new DataView({ fieldFormats: services.fieldFormats }); | ||
| } |
There was a problem hiding this comment.
Looking good from my end, it's great, that we are now be able to do this, and no longer persist a "foreign" data view in this case. question is, if this could be further optimized, we're saving redundant settings here
neither title, nor sourceFilters, nor fieldFormats, nor runtimeFieldMap, ...
would be necessary to be persisted as serialized values, since those are just defaults. just persisting what's necessary, would also make it easier to debug, and save a bit of space (not much, but well, a tiny little bit)
There was a problem hiding this comment.
Created this as to address it as a separate issue - #180429
|
/ci |
1 similar comment
|
/ci |
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @mattkime |
|
I guess this can be closed? |
Summary
Supply an empty data view when there's no FROM clause and therefore no field list.
Closes #163417